Add supporting multi-target scraping#1120
Open
iamhalje wants to merge 17 commits intopercona:mainfrom
Open
Conversation
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
…ndle concurrent access Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Author
|
any feedback? can be produced |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1120 +/- ##
==========================================
- Coverage 70.88% 63.88% -7.01%
==========================================
Files 28 30 +2
Lines 3569 3162 -407
==========================================
- Hits 2530 2020 -510
- Misses 904 997 +93
- Partials 135 145 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
can be update this PR, if give feedback.. (this version month working in production without problems) |
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Signed-off-by: Dmitry Ponomaryov <iamhalje@gmail.com>
Author
|
this patch has been running under load for some time without issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for multi-target scraping via the
/scrape?target=...endpoint, even when--mongodb.uriis configured globally. This allows dynamic discovery and monitoring of MongoDB instances without restarting the exporter, improving integration with Prometheus service discovery and multi-target configurations.https://prometheus.io/docs/guides/multi-target-exporter/
Unlike the previous approach, where scraping was limited to the fixed list of instances specified by
--mongodb.uriand when need added new host, need restart exported, this change enables flexible, on-demand querying of arbitrary MongoDB targets through the/scrape?target=...parameter.Related issue: #878 — Multi target without need for specifying --mongodb.uri
Leave notes to the reviewers if you need to focus their attention on something specific:
This change affects core logic related to connection handling and target resolution. Existing setups using
--mongodb.uricontinue to work without changes. At the same time, users can now add dynamic targets seamlessly.If you notice anything that could affect stability or how can do more good with code structure, caching or backward compatibility, especially in edge cases or other contributed rights, please let me know and we fixed this.