tower-abci: add bound tcp server #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a `Server::bind_tcp` method returning a `BoundTcpServer` server to query the local address the server is bound to. To avoid clashing on occupied ports, blackbox tests bind to the zero-port (as in `0.0.0.0:0`) and are assigned a random free port by the system. Because the `Server::listen_tcp` method binds and accepts a port in one go, it is currently not possible to programmatically return the port the server bound. With this patch binding a port and accepting requests is split into a `Server::bind_tcp` and `BoundTcpServer::accept`. `Server::listen_tcp` is implemented in terms of these.
Contributor
Author
|
It looks like CI failed due to unrelated clippy lints (similar to other open PRs that fail due to clippy). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
Server::bind_tcpmethodreturning a
BoundTcpServerserver to querythe local address the server is bound to.
To avoid clashing on occupied ports, blackbox
tests bind to the zero-port (as in
0.0.0.0:0)and are assigned a random free port by the system.
Because the
Server::listen_tcpmethod bindsand accepts a port in one go, it is currently not
possible to programmatically return the port the
server bound.
With this patch binding a port and accepting
requests is split into a
Server::bind_tcpandBoundTcpServer::accept.Server::listen_tcpisimplemented in terms of these.
This is only implemented for the v0.38 server.
If the direction is acceptable I can extend this
to the other servers.