Bump version to 1.4.3 and update CHANGELOG; fix threshold parsing in … #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the app version to 1.4.3, updates the CHANGELOG, fixes threshold parsing for DKG requests, and adjusts the confirmation icon color in the open request tab.
- Version bump to 1.4.3+152 with corresponding changelog entry
- Use
int.tryParsewith a default threshold of 2 for DKG requests - Change confirmation icon color from
primarytoprimaryContainer
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pubspec.yaml | Bump version from 1.4.2+151 to 1.4.3+152 |
| lib/widgets/wallet/roast_group/tabs/request_dkg_tab.dart | Replace int.parse with int.tryParse fallback |
| lib/widgets/wallet/roast_group/tabs/open_request_tab.dart | Update confirmation icon color to primaryContainer |
| CHANGELOG.md | Add 1.4.3 section with “More dark mode fixes” |
Comments suppressed due to low confidence (1)
lib/widgets/wallet/roast_group/tabs/open_request_tab.dart:318
- Switching the icon color to
primaryContainermay reduce contrast against certain backgrounds. Verify it meets accessibility contrast requirements or choose a more contrasting color.
color: Theme.of(context).colorScheme.primaryContainer,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…DKG requests
fixes #299