FIX: Filter non-scalar env values to prevent PHP 8.2 proc_open warnings #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.2+ throws "Array to string conversion" warning when proc_open receives environment variables containing non-scalar values. Added filtering to ensure only scalar values are passed.
Contributor
|
Sounds like maybe https://bugs.php.net/bug.php?id=75712, which was fixed in PHP 8.2.17. |
alecpl
reviewed
Feb 20, 2025
| $this->_pipes, | ||
| null, | ||
| $env, | ||
| array_filter($env, 'is_scalar'), |
Contributor
There was a problem hiding this comment.
I'd probably do this once, when $env is being set. And add a comment describing why it is needed.
alecpl
added a commit
that referenced
this pull request
Apr 6, 2025
Contributor
|
Fixed via 2826945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.2+ throws "Array to string conversion" warning when
proc_openreceives environment variables containing non-scalar values.Added filtering to ensure only scalar values are passed.