Skip to content

Conversation

@Hipska
Copy link
Contributor

@Hipska Hipska commented May 27, 2025

Fixes #52

@mcdruid
Copy link
Contributor

mcdruid commented Jun 2, 2025

Thanks.

The failure on PHP 5.4 is unrelated; we're likely to remove that check soon (discussion in #51). Looks like we also need to tidy up the test config.. again unrelated.

I don't think we necessarily need to add specific tests to show the new return value if _writeBlock fails (although if we can think of an easy way to do that.. great).

However, we should reassure ourselves that method is exercised by the test suite - and therefore that this change doesn't introduce a regression during normal / successful operation.

@Hipska
Copy link
Contributor Author

Hipska commented Jun 11, 2025

Thanks @mcdruid. Do you expect anything from me?

@Hipska
Copy link
Contributor Author

Hipska commented Jul 16, 2025

@mcdruid any feedback? I would like to get this one landed soon.

@mcdruid
Copy link
Contributor

mcdruid commented Jul 16, 2025

Sorry I meant to reply sooner.

Generally I would avoid starting to refactor anything that's not absolutely necessary to change in order to address a specific issue.

I'm trying to make some progress on tweaking the test config as part of retiring support for ancient PHP versions, hoping that will unblock getting a couple of changes into a new release.

However, I am not a fully-fledged PEAR maintainer (in terms of knowledge of some of the more arcane processes apart from anything else) and am not able to do full releases of this project myself.

So I'm afraid I don't know how soon this - and other fixes - will get unblocked and make it into a release.

@Hipska
Copy link
Contributor Author

Hipska commented Jul 16, 2025

I'm just wondering what needs to be done on my part to get this PR accepted and merged..

@ashnazg
Copy link
Member

ashnazg commented Jul 16, 2025

@mcdruid , I'll see if I can make some time this weekend to help catch things up here.

@mcdruid
Copy link
Contributor

mcdruid commented Jul 17, 2025

Thanks @ashnazg

Rather than going into the details of what I think we need to do here, I spun up #57

@ashnazg ashnazg self-assigned this Jul 19, 2025
@ashnazg ashnazg merged commit 0910594 into pear:master Jul 19, 2025
9 of 10 checks passed
@Hipska Hipska deleted the fix/write_return branch July 23, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_writeBlock always returns true

3 participants