-
-
Notifications
You must be signed in to change notification settings - Fork 34
Fix return value of _writeBlock #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks. The failure on PHP 5.4 is unrelated; we're likely to remove that check soon (discussion in #51). Looks like we also need to tidy up the test config.. again unrelated. I don't think we necessarily need to add specific tests to show the new return value if However, we should reassure ourselves that method is exercised by the test suite - and therefore that this change doesn't introduce a regression during normal / successful operation. |
|
Thanks @mcdruid. Do you expect anything from me? |
|
@mcdruid any feedback? I would like to get this one landed soon. |
|
Sorry I meant to reply sooner. Generally I would avoid starting to refactor anything that's not absolutely necessary to change in order to address a specific issue. I'm trying to make some progress on tweaking the test config as part of retiring support for ancient PHP versions, hoping that will unblock getting a couple of changes into a new release. However, I am not a fully-fledged PEAR maintainer (in terms of knowledge of some of the more arcane processes apart from anything else) and am not able to do full releases of this project myself. So I'm afraid I don't know how soon this - and other fixes - will get unblocked and make it into a release. |
|
I'm just wondering what needs to be done on my part to get this PR accepted and merged.. |
|
@mcdruid , I'll see if I can make some time this weekend to help catch things up here. |
Fixes #52