Skip to content

Relax activesupport version constraint #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlarraz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Relax activesupport version constraint #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flip.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Gem::Specification.new do |s|
s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
s.require_paths = ["lib"]

s.add_dependency("activesupport", ">= 4.0", "<= 5.2")
Copy link

@montanalow montanalow May 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

activesupport uses good deprecation and consistent migration paths for end users. Gems should typically avoid upper bounding on widely shared and well tested dependencies, unless there are known incompatibilities.

s.add_dependency("activesupport", ">= 4.0", "< 6")
s.add_dependency("i18n")

s.add_development_dependency("actionpack")
Expand Down