feat: add error-on-diff flag for summary command#199
Merged
daveshanley merged 1 commit intopb33f:mainfrom May 15, 2025
Merged
Conversation
daveshanley
approved these changes
May 15, 2025
Member
daveshanley
left a comment
daveshanley
left a comment
There was a problem hiding this comment.
LGTM! Thank you for adding!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
This is an implementation of what I opened as an issue in #198. Adding the
--error-on-diffflag to thesummarycommand will make the tool terminate with an error on any (be it non-breaking or breaking) differences. This basically has the same effect as the --fail-on-diff flag in oasdiff tool.Let me know your thoughts.