Check items when validating enums in array query parameters. #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2025 09:16
Only validate enums based on the provided item vs. the unparsed value.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 96.60% 96.60%
=======================================
Files 32 32
Lines 3391 3391
=======================================
Hits 3276 3276
Misses 115 115
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daveshanley
approved these changes
May 17, 2025
Member
daveshanley
left a comment
daveshanley
left a comment
There was a problem hiding this comment.
LGTM. thank you for your contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #146.
Check the item against the enum definition when validating arrays of query parameters. Previously, the unparsed query parameter value was used. This was problematic for non-exploded-form-style-arrays. In that case, validation errors would be thrown for correct requests. For example, if you accept only
codandhaddock, and the parameter is set tocod,haddock, it'd testcod,haddockinstead ofcodandhaddock.