Skip to content

Conversation

@FFFFFFatsLan
Copy link

fix #135

@FFFFFFatsLan
Copy link
Author

@wizardishungry @arnaldur @k1LoW @daveshanley can you please take a look ? Thanks.

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (224827e) to head (b81eba2).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          29       29           
  Lines        3167     3167           
=======================================
  Hits         3157     3157           
  Misses         10       10           
Flag Coverage Δ
unittests 99.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daveshanley daveshanley merged commit 4340576 into pb33f:main Apr 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question about parameter validation: the validation error has been overwritten.

2 participants