Skip to content

Conversation

@Rishabh-Daga
Copy link

@Rishabh-Daga Rishabh-Daga commented Mar 7, 2025

fixes #126

@Rishabh-Daga
Copy link
Author

Rishabh-Daga commented Apr 3, 2025

@wizardishungry @arnaldur @k1LoW @daveshanley can you please take a look ? Thanks.

@Rishabh-Daga Rishabh-Daga changed the title support for path validation for odata-formatted openapi specs fix: support for path validation for odata-formatted openapi specs Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 91.01124% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@9a731fd). Learn more about missing BASE report.
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
helpers/regex_maker.go 90.76% 6 Missing ⚠️
parameters/path_parameters.go 89.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage        ?   99.44%           
=======================================
  Files           ?       30           
  Lines           ?     3247           
  Branches        ?        0           
=======================================
  Hits            ?     3229           
  Misses          ?       18           
  Partials        ?        0           
Flag Coverage Δ
unittests 99.44% <91.01%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daveshanley
Copy link
Member

Can you bump coverage please?

@Rishabh-Daga
Copy link
Author

Rishabh-Daga commented Apr 10, 2025

Can you bump coverage please?

Done. @daveshanley can you take a look again ?

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, just a couple of docs to be added.

@Rishabh-Daga
Copy link
Author

LGTM, thanks, just a couple of docs to be added.

Added. Can you verify ? Thanks.

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daveshanley daveshanley merged commit 86b8d0e into pb33f:main Apr 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OData formatted OpenAPI Spec validations not working

3 participants