Skip to content

Conversation

@trusta
Copy link

@trusta trusta commented Feb 20, 2025

Separate the integer type and the number type in validation of all parameters.

@trusta
Copy link
Author

trusta commented Apr 14, 2025

@daveshanley How can I trigger a Codecov Report?

@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.88%. Comparing base (9569c25) to head (d2fad37).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   96.85%   96.88%   +0.02%     
==========================================
  Files          34       34              
  Lines        3626     3786     +160     
==========================================
+ Hits         3512     3668     +156     
- Misses        114      118       +4     
Flag Coverage Δ
unittests 96.88% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daveshanley
Copy link
Member

Coverage is important. I can't let this through without higher coverage.

@trusta trusta force-pushed the integer-support branch from 851dc0a to 2b134c4 Compare May 28, 2025 13:03
@trusta trusta force-pushed the integer-support branch from 2b134c4 to d2fad37 Compare May 28, 2025 13:18
@trusta
Copy link
Author

trusta commented May 28, 2025

@daveshanley I fixed the coverage. Thank you for your interest :)

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice upgrade. Thank you for your contribution!

@daveshanley daveshanley merged commit 018bcc4 into pb33f:main Jun 2, 2025
4 checks passed
@trusta trusta deleted the integer-support branch June 3, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants