-
Notifications
You must be signed in to change notification settings - Fork 77
Introduce treefmt-nix as a universal formatter infra #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 20174624583Details
💛 - Coveralls |
3c23e6e to
758b1ab
Compare
|
I think any such change should enforce the same formatting rules in CI, otherwise I can see things getting out of sync quickly |
|
Good point, marking as draft to add this formatting to the CI |
7e0f278 to
9b5aef0
Compare
caa9171 to
c9f1763
Compare
|
I gave it a college try to add formatting to dart but I kept getting wild diffs in the CI formatter, I don't understand why as dart is notable for having a very strict formatting style. I could never get any formatting to match the CI dart formatter locally |
nothingmuch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix code looks good, but i think we should figure out what's wrong with dart formatting before merging
|
per #1220 (comment), we should add an additional rust-overlay toolchain based on the toolchain.toml @spacebear21 is this what you meant here? #1221 (comment) |
I was just asking for a CI workflow that enforces the formatting rules applied in this PR (when it was posted originally it applied formatting changes but there was no CI validation so I was concerned about eventual regressions). |
84062b1 to
3e59a17
Compare
|
Are we even properly linking to our |
ab29ebc to
d906254
Compare
|
This commit d906254 I manually made the changes requested by the CI formatter to make it happy but ideally we would have the same options or whatever is causing these changes to be made directly in the https://dart.dev/tools/dart-format the dart formatting docs are not really clear on how to add a lot of options |
69bc460 to
d906254
Compare
840ed52 to
7da0a9f
Compare
Run: dart format nixfmt prettier ruff format rustfmt shellcheck shfmt taplo format
7da0a9f to
78de039
Compare
when using git blame you will need to ensure that this ignore file is respected with `git blame --ignore-revs-file <file>` to ensure all commits listed there are properly ignored.
78de039 to
42266e2
Compare
This commit adds treefmt-nix as a universal formatter to enforce formatting across all languages in the mono repo. This adds support for formatting dart, javascript, toml, and python beyond out current existing formatters.
42266e2 to
3fff1aa
Compare
nothingmuch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK. Also confirmed nix flake check is happy for all commits.
This pulls in a commit from #1027 but does not include the ci formatting from there as I believe that we can simply use treefmt-nix for all file types in the ci
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.