Refactor/Fix missing foreign key index detection + missing FK constraints heuristics and update tests

[chaadow]

Missing FK indices Algorithm

• Simplify the logic for detecting missing foreign key indexes by directly using foreign key information.
• Update tests to reflect changes in foreign key and index detection

==> I went from 67 missing foreign keys ( with false positives ) to over 200 in my production application 💀. I checked manually and indeed, it turns out I have a LOT of missing indices. Which for me indicates that the DetectFkColumn was a bit weird ... EDIT: indeed the root cause was that cases such as user_account_id were returning user instead of user_account!

missing Fk constraints check heuristics algorithm

Enhance missing foreign key detection (missing_fk_constraints) logic and update tests

• Refactor the logic to identify missing foreign key constraints by considering existing constraints and polymorphic associations
• Add tests to ensure columns with existing foreign key constraints and polymorphic associations are correctly excluded from results.

Add ignore list to missing_fk_constraint check

• Introduce a new IgnoreList class which can be later be used in other checks if needed. As input it takes an ignore list, then can determine if a column in a table is ignored based on the ignore list.

Enhance and Fix foreign key column detection logic

• Refactor FkDetectColumn class to improve detection of foreign key columns, accommodating underscored prefixes and mixed-case names, such as user_account_id
• Improve the pluralization edge cases

related to pawurb/rails-pg-extras#58

[chaadow]

I'm going to push later the ignore list feature as well

and if I got time/succeed, I will have to improve the DetectFkColumn algorithm. i suspect we can better improve the pluralize part

[chaadow]

@pawurb I found the root cause for DetectFkColumn. I knew something was wrong when I went from 67 missing foreign keys to over 200 ( even with the algorithm change to directly check foreign keys from the database)

the main isuse was this line: table_name = column_name.split("_").first which unfortunately did not handle column names suchs user_account_id and was returning user instead of user_account

I've tested the fix on my production app, and with it I was able to detect 5 real missing FK constraints!

[chaadow]

@pawurb I believe I'm done with the improvements and fixes, I don't have anything else for now. You can review / cut a release whenever you can!

[pawurb]

@chaadow thanks a lot! I'll proceed with releasing this and related rails-pg-extras changes