fix: normalize ssh.github.com to github.com for URL generation#232
Open
wuwb wants to merge 1 commit intopaulirish:masterfrom
Open
fix: normalize ssh.github.com to github.com for URL generation#232wuwb wants to merge 1 commit intopaulirish:masterfrom
wuwb wants to merge 1 commit intopaulirish:masterfrom
Conversation
When using GitHub's SSH-over-HTTPS gateway (ssh.github.com), the remote URL is returned as ssh://git@ssh.github.com/..., causing git-open to generate invalid URLs like https://ssh.github.com/... This fix normalizes the domain back to github.com so that the generated browser URL is always valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using GitHub's SSH-over-HTTPS gateway (configured via
~/.ssh/config), the remote URL is returned asssh://git@ssh.github.com/..., causinggit-opento generate an invalid URL likehttps://ssh.github.com/owner/repowhich cannot be opened in a browser.This commonly happens when connecting to GitHub via SSH over port 443 (e.g., corporate networks that block port 22):
Fix
Normalize the
ssh.github.comgateway hostname back togithub.combefore generating the browser URL.Before vs After
ssh://git@ssh.github.com/owner/repohttps://ssh.github.com/...https://github.com/...git@github.com:owner/repo(no change)https://github.com/...https://github.com/...