DRAFT: Create Figma files with Claude#49
DRAFT: Create Figma files with Claude#49andrew-ronaldson wants to merge 4 commits intopatternfly:mainfrom
Conversation
…le URL Replace the community file link with the direct design file URL for the PatternFly 6: Components library. Made-with: Cursor
✅ Actions performedFull review triggered. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
plugins/pf-figma/skills/pf-figma-design/SKILL.md (1)
10-23: Add explicit "Quality gates" section referencing contribution standards.The repo standards in
CONTRIBUTING-SKILLS.mdandCONTRIBUTING.mdestablish requirements for skills in this repository, including alignment with Anthropic's skill-creator plugin guidance. Include a brief section that points contributors to these standards to make review criteria explicit. Guidelines:CONTRIBUTING.md,CONTRIBUTING-SKILLS.md, Anthropic skill-creator plugin.Applies to lines 10-23 and 393-401.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/pf-figma/skills/pf-figma-design/SKILL.md` around lines 10 - 23, Add a new "Quality gates" section in SKILL.md (near the Prerequisites heading and also mirror it toward the end where contributor guidance appears) that explicitly references the repo contribution standards: point to CONTRIBUTING.md and CONTRIBUTING-SKILLS.md and call out alignment with Anthropic's skill-creator guidance (link/name). State the required review criteria briefly (e.g., adherence to contribution docs, tests, examples, and pattern-library usage) and instruct contributors to follow the Anthropic skill-creator plugin guidance when authoring or updating this skill.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@plugins/pf-figma/skills/pf-figma-design/references/pf-component-hierarchy.md`:
- Around line 7-12: The unlabeled fenced diagram blocks in
pf-component-hierarchy.md need a language identifier to satisfy markdownlint
MD040; for each ASCII hierarchy block (e.g., the Modal diagram and the other
unlabeled blocks at the ranges listed) update the opening fence from ``` to
```text so each diagram block is labeled (apply the same change to the blocks at
24-34, 45-52, 62-70, 80-88, 97-102, 110-115, 126-130, 144-152, 166-176, 187-193,
212-220, 234-242, 255-263); ensure only the opening fence is changed to include
"text" and the diagram content itself remains unchanged.
---
Nitpick comments:
In `@plugins/pf-figma/skills/pf-figma-design/SKILL.md`:
- Around line 10-23: Add a new "Quality gates" section in SKILL.md (near the
Prerequisites heading and also mirror it toward the end where contributor
guidance appears) that explicitly references the repo contribution standards:
point to CONTRIBUTING.md and CONTRIBUTING-SKILLS.md and call out alignment with
Anthropic's skill-creator guidance (link/name). State the required review
criteria briefly (e.g., adherence to contribution docs, tests, examples, and
pattern-library usage) and instruct contributors to follow the Anthropic
skill-creator plugin guidance when authoring or updating this skill.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b5ac7266-6a9a-47a8-a8b0-0667385d0b24
📒 Files selected for processing (4)
plugins/pf-figma/skills/pf-figma-design/SKILL.mdplugins/pf-figma/skills/pf-figma-design/references/pf-component-hierarchy.mdplugins/pf-figma/skills/pf-figma-design/references/pf-token-guide.mdplugins/pf-figma/skills/pf-figma-design/references/pf-variant-guide.md
| ``` | ||
| Modal (overlay frame with backdrop) | ||
| ├── ModalHeader (title + close button) | ||
| ├── ModalBody (scrollable content area) | ||
| └── ModalFooter (action buttons) | ||
| ``` |
There was a problem hiding this comment.
Add language identifiers to fenced blocks to satisfy markdownlint (MD040).
All hierarchy diagrams should use a fence language (e.g., text) so docs lint passes cleanly.
Suggested doc-lint fix
-```
+```text
Modal (overlay frame with backdrop)
...
-```
+```Apply the same ```text change to each unlabeled diagram block in this file.
Guidelines used: CONTRIBUTING.md (documentation lint cleanliness before merge).
Also applies to: 24-34, 45-52, 62-70, 80-88, 97-102, 110-115, 126-130, 144-152, 166-176, 187-193, 212-220, 234-242, 255-263
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 7-7: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@plugins/pf-figma/skills/pf-figma-design/references/pf-component-hierarchy.md`
around lines 7 - 12, The unlabeled fenced diagram blocks in
pf-component-hierarchy.md need a language identifier to satisfy markdownlint
MD040; for each ASCII hierarchy block (e.g., the Modal diagram and the other
unlabeled blocks at the ranges listed) update the opening fence from ``` to
```text so each diagram block is labeled (apply the same change to the blocks at
24-34, 45-52, 62-70, 80-88, 97-102, 110-115, 126-130, 144-152, 166-176, 187-193,
212-220, 234-242, 255-263); ensure only the opening fence is changed to include
"text" and the diagram content itself remains unchanged.
1 participant
Summary by CodeRabbit