-
Notifications
You must be signed in to change notification settings - Fork 1
Fix WAS award progress inconsistency between main awards page and detail page #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: patrickrb <[email protected]>
patrickrb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot it seems like the entire WAS award is broken now, no data is showing for any states
…ad of type filter Co-authored-by: patrickrb <[email protected]>
Fixed the issue! The problem was that my original fix used The new approach:
Commit: 5594d35 |
patrickrb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patrickrb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the main /awards page is showing that I have 49/50 for WAS award, but the WAS page is showing I have 50/50 and 100%
…l page Co-authored-by: patrickrb <[email protected]>
Fixed the inconsistency! The main awards page was showing confirmed states (49/50) while the WAS detail page was showing worked states (50/50). Both pages now consistently use worked states as the primary progress metric, so you'll see 50/50 (100%) on both pages. The change aligns with amateur radio conventions where "worked" (contacted) is the main progress indicator, and "confirmed" (QSL received) is shown separately as additional achievement. Commit: cb8f219 |
patrickrb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested deployed env, LGTM, merging




The WAS (Worked All States) award was displaying inconsistent progress between the main awards page and the detail page, confusing users about their actual progress.
Problem
/awards): Showed 49/50 (98%) using confirmed states/awards/was): Showed 50/50 (100%) using worked statesThis inconsistency occurred because the two pages were using different metrics:
confirmed_states/total_states(states with QSL confirmation)worked_states/total_states(states contacted)Solution
Updated the main awards page to use the same metric as the detail page:
confirmed_statestoworked_statesconfirmed_states >= 50toworked_states >= 50progress_percentageproperty to TypeScript interfaceBoth pages now consistently show worked states as the primary progress metric, with confirmed states displayed separately as additional achievement. This aligns with amateur radio conventions where "worked" (contacted) is the main progress indicator.
Result
Users now see consistent 50/50 (100%) progress on both pages when they have worked all 50 states, eliminating confusion about their WAS award status.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.