-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
4c0ca97 to
0c73352
Compare
| "passageidentity.openapi_client.models": "passageidentity/openapi_client/models", | ||
| }, | ||
| install_requires=[ | ||
| "aenum", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this didn't seem to be used at all
| 'importlib-metadata >= 1.0 ; python_version < "3.12"', | ||
| "pydantic", | ||
| "pyjwt", | ||
| "python-dateutil", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip list will show that the following are still installed without them being explicitly listed here:
python-dateutil
typing_extensions
urllib3
181ee84 to
beec480
Compare
| tests_require=["pytest"], | ||
| test_suite="tests", | ||
| python_requires=">=3.7", | ||
| python_requires=">=3.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i originally tried setting everything to work with 3.7 but there's such a massive difference with dependency support that it was a big headache. our use of importlib-metadata also doesn't even work with 3.7 so i figured no one is using our package with that version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't be in vcs
beec480 to
54b7e29
Compare
|



What's New?
To test:
pytestpytestScreenshots (if appropriate):
Type of change
Checklist:
Additional context