Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

Conversation

@ctran88
Copy link
Contributor

@ctran88 ctran88 commented Dec 2, 2024

What's New?

  • Pins deps to latest
  • Removes unused deps
  • Removes deps that are already pulled in by the libraries using them

To test:

  1. Open project in dev container
  2. pytest
  3. All tests should pass
  4. Try removing a dependency from the new list
  5. Rebuild dev container
  6. pytest
  7. Tests should fail with an error that the package cannot be found

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 force-pushed the PSG-4844-update-deps branch from 4c0ca97 to 0c73352 Compare December 2, 2024 22:03
"passageidentity.openapi_client.models": "passageidentity/openapi_client/models",
},
install_requires=[
"aenum",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this didn't seem to be used at all

'importlib-metadata >= 1.0 ; python_version < "3.12"',
"pydantic",
"pyjwt",
"python-dateutil",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip list will show that the following are still installed without them being explicitly listed here:

python-dateutil
typing_extensions
urllib3

@ctran88 ctran88 requested a review from a team December 2, 2024 22:04
@ctran88 ctran88 force-pushed the PSG-4844-update-deps branch 8 times, most recently from 181ee84 to beec480 Compare December 2, 2024 22:50
tests_require=["pytest"],
test_suite="tests",
python_requires=">=3.7",
python_requires=">=3.8",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i originally tried setting everything to work with 3.7 but there's such a massive difference with dependency support that it was a big headache. our use of importlib-metadata also doesn't even work with 3.7 so i figured no one is using our package with that version.

Copy link
Contributor Author

@ctran88 ctran88 Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be in vcs

Base automatically changed from PSG-5152-new-class-new-method to main December 5, 2024 22:27
@ctran88 ctran88 force-pushed the PSG-4844-update-deps branch from beec480 to 54b7e29 Compare December 5, 2024 22:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2024

@ctran88 ctran88 merged commit 32acfea into main Dec 6, 2024
6 checks passed
@ctran88 ctran88 deleted the PSG-4844-update-deps branch December 6, 2024 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants