fix: add "passage-node" prefix to version header #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertrmz
reviewed
Feb 12, 2025
src/classes/Passage/Passage.ts
Outdated
| ...config?.headers, | ||
| 'Authorization': `Bearer ${config?.accessToken}`, | ||
| 'Passage-Version': process.env.npm_package_version || '', | ||
| 'Passage-Version': `passage-node ${process.env.npm_package_version ?? ''}`, |
Contributor
There was a problem hiding this comment.
It might be cleaner to leave the header unset if process.env.npm_package_version isn’t defined, to avoid a trailing space in "passage-node ".
Contributor
Author
There was a problem hiding this comment.
do you think it would still be useful to log requests that are coming from this sdk even if the version were missing instead of not at all?
Contributor
There was a problem hiding this comment.
Yeah possibly. The only case where this would happen seems to be if someone were testing the source repo directly rather than the package itself. Using a dev or v0.0.0 placeholder could help in those cases.
… the source code instead of the published package
|
bertrmz
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
adds missing
passage-nodeprefix to version header valueScreenshots (if appropriate):
Type of change
Checklist:
Additional context