Skip to content

fix: Prevent double-encoded presigned urls from s3 #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Prevent double-encoded presigned urls from s3 #336

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c922b8
fix: Use the unencoded file name instead of the encoded one to submit…
AdrianCurtin Aug 13, 2025
974a3eb
Add test for double encoding
AdrianCurtin Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,10 +228,12 @@ class S3Adapter {
}

const fileKey = `${this._bucketPrefix}${fileName}`;
// For presigned URLs, use the original unencoded filename to prevent double encoding
const presignedFileKey = `${this._bucketPrefix}${filename}`;

let presignedUrl = '';
if (this._presignedUrl) {
const params = { Bucket: this._bucket, Key: fileKey };
const params = { Bucket: this._bucket, Key: presignedFileKey };
const options = this._presignedUrlExpires ? { expiresIn: this._presignedUrlExpires } : {};

const command = new GetObjectCommand(params);
Expand Down