Open
Conversation
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
koute
reviewed
Jan 13, 2026
CLAUDE.md
Outdated
|
|
||
| ## Project Overview | ||
|
|
||
| PolkaVM is a general-purpose RISC-V based virtual machine targeting RV32EM. It provides secure sandboxed execution with both an interpreter and a JIT compiler backend. |
Collaborator
There was a problem hiding this comment.
Not against adding this, but it should be manually edited before committing so that it makes sense. For example:
- RV32EM is not what we target anymore (although 32-bit is still technically supported).
- Saying which exact Rust versions are used is useless, and will go out of date eventually.
- Incorrect or irrelevant points should be removed (e.g. '
linker.rs: Runtime linking of host functions' is incorrect and the naming scheme is mostly a historical artifact since I was originally basing this onwasmtime's API, or "Performs register allocation via regalloc2" is a minor detail and gross misrepresentation that will most likely confuse the AI, since register allocation is only done in a very specific case) - The environment variable section is probably useless
etc.
If you're not sure about something feel free to just remove it. :P
Member
Author
There was a problem hiding this comment.
I thought claude may have some logic in what it puts inside this file when generating it. It did actually not too bad in creating the file for paritytech/revive. Apparently here it's just mainly AI slop.
Manually reviewed it and changed a few things. I don't know yet what exactly to put in there and what not. But the file is intended to be changed over time anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So others don't have to regenerate it again.