Skip to content

fix(core): Copy buffer in replaceStream to prevent corruption from buffer reuse #10258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reidbarber wants to merge 3 commits into
base: v2
Choose a base branch
from
+385 −4
Open

fix(core): Copy buffer in replaceStream to prevent corruption from buffer reuse #10258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f49f1d4
fix(core): copy buffer in replaceStream to prevent corruption
reidbarber Jan 16, 2026
b803182
test(core): add tests for WriteBundleRequest replaceStream
reidbarber Jan 16, 2026
5825b24
fix lint
reidbarber Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/core/core/src/requests/WriteBundleRequest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,9 @@ async function runCompressor(
}
}

function replaceStream(hashRefToNameHash) {
export function replaceStream(
hashRefToNameHash: Map<string, string>,
): Transform {
let boundaryStr = Buffer.alloc(0);
let replaced = Buffer.alloc(0);
return new Transform({
Expand Down Expand Up @@ -348,9 +350,10 @@ function replaceStream(hashRefToNameHash) {
replacedLength - BOUNDARY_LENGTH,
replacedLength,
);
let strUpToBoundary = replaced.subarray(
0,
replacedLength - BOUNDARY_LENGTH,
// Copy buffer to avoid reuse issues - subarray returns a view that can be
// corrupted if the underlying buffer is modified before the data is written
let strUpToBoundary = Buffer.from(
replaced.subarray(0, replacedLength - BOUNDARY_LENGTH),
);
cb(null, strUpToBoundary);
},
Expand Down
Loading