Fix: boolean field not using force_values when the form initializes it.#868
Open
jeffdico wants to merge 2 commits intopallets-eco:mainfrom
Open
Fix: boolean field not using force_values when the form initializes it.#868jeffdico wants to merge 2 commits intopallets-eco:mainfrom
jeffdico wants to merge 2 commits intopallets-eco:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue you are attempting to fix.
The booleanField is not using the false_values to check the formdata value passed to it. it just sets what ever vallue passed as bool.
Link to any relevant issues or pull requests.
Describe what this patch does to fix the issue.
This patch makes a call to process_formdata method so as to enforce using false_values set when creating the field in the form class.