Skip to content

Conversation

@bjornbm
Copy link
Contributor

@bjornbm bjornbm commented Mar 10, 2025

Changes avoiding bash-specifics and GNU extensions for grep.

These now run on, for example, Alpine Linux (with BusyBox grep) and with dash shell.

@hugomg
Copy link
Member

hugomg commented Mar 10, 2025

I was more used to debian, which uses dash by default but also has bash installed and usable via shebang. If I understand you correctly, alpine doesn't have bash at all?

The testing scripts most often used by developers, which may be more willing to install dependencies. What's the context for alpine in particular? Is it for CI?

@bjornbm
Copy link
Contributor Author

bjornbm commented Mar 10, 2025

Alpine is popular in CI and anywhere you want a small linux. I'm using it in a VM (with macpine) to test some of the commits I'm sending you.

Alpine doesn't come with bash, but it can be installed (apk add bash).

In some environments bash is not available due to the license (obscure example).

I'm not sure the long grep flags are supported on all the BSDs… it seems they are not on OpenBSD.

Agreed that most developers will have/be willing to install bash on their dev machines. And GNU (or other) grep. And I could too on my VM. But I feel the cost of portability is low here as the scripts didn't really rely on “bashisms” or GNU extensions.

@hugomg hugomg merged commit 22883b0 into pallene-lang:master Mar 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants