Add a note to make sure bootable OS installer ISO is used#28
Merged
Conversation
sudomateo
reviewed
Jan 19, 2026
Contributor
sudomateo
left a comment
There was a problem hiding this comment.
Thanks for working on this! I left some non-blocking comments and suggestions to, hopefully, make the wording more concise without losing the meaning. Let me know what you think!
Co-authored-by: Matthew Sanabria <matthew@sanabria.email>
sudomateo
reviewed
Jan 20, 2026
Contributor
sudomateo
left a comment
There was a problem hiding this comment.
Looking great! Just some nitpick suggestions and a question.
Contributor
|
Jumping in via email here - couldn’t we just check to see if the image is bootable? That should probably be enough. On Jan 19, 2026, at 17:34, Matthew Sanabria ***@***.***> wrote:
@sudomateo commented on this pull request.
In README.adoc:
+
+To validate your Windows ISO, check the `VolumeId` using `7z`:
+
+```bash
+# Correct!
+$ 7z l windows.iso | grep VolumeId
+ VolumeId: UDF Volume
+ LogicalVolumeId: SSS_X64FREE_EN-US_DV9
+
+# Incorrect.
+$ 7z l win-server-2022.iso | grep VolumeId
+ VolumeId: UDF Volume
+ LogicalVolumeId: SERVER_FOD_LP_X64FRE_MULTI_DV9
+```
+
+A valid ISO usually contains `FRE` as the primary descriptor, and should not contain strings that indicate supplemental content, such as `FOD` or `LP`. If you see `FOD` or `LP` in the `VolumeId`, it means you downloaded the wrong ISO. This is not bootable and image build script will fail.
I looked at the code snippet again and both the good and bad image have FRE in it. Do we need to further clarify or perhaps just be explicit that the negative cases to watch out for are those with FOD or LP.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
Co-authored-by: Matthew Sanabria <matthew@sanabria.email>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to SSE-185.
Relates to https://github.com/oxidecomputer/solutions-software-engineering/issues/46.