Conversation
…lity Added phpcs:disable comments to all source, example, and test files so the library passes WordPress coding standards when bundled as a vendor dependency inside WordPress plugins. No functional code changes — only inline PHPCS comment directives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
phpcs:disablecomments to all source, example, and test files so the library passes WordPress coding standards when bundled as a vendor dependency inside WordPress plugins via WordPress Plugin Check.Problem
When
owlstack-coreis installed as a Composer dependency inowlstack-wp, WordPress Plugin Check scans the vendor files against WordPress Coding Standards. Since this is a framework-agnostic library that intentionally uses native PHP functions (cURL, json_encode, file_get_contents, base64_encode, etc.), it triggers 134 errors and 52 warnings across 16 source files, plus 239 errors and 39 warnings across 27 example files, and 125 warnings across 11 test files.Solution
Added file-level
phpcs:disabledirectives with clear explanations to each affected file:WordPress.Security.EscapeOutput.ExceptionNotEscaped— Exceptions are not WordPress output in this framework-agnostic libraryWordPress.WP.AlternativeFunctions— Native PHP functions (cURL, json_encode, file_get_contents) required for framework independenceWordPress.PHP.DiscouragedPHPFunctions— base64_encode/urlencode required for OAuth and API operationsWordPress.PHP.NoSilencedErrors— @Unlink used for temporary file cleanup in HttpClientUniversal.Operators.DisallowShortTernary— Short ternary intentionally used for concise null/empty handlingChanges
src/— added specific phpcs:disable per fileexamples/— added blanket phpcs:disabletests/— added phpcs:disable for AlternativeFunctionsVerification