MULTIARCH-5642: Remove uporcessed enoexecEvents on error #726
MULTIARCH-5642: Remove uporcessed enoexecEvents on error #726AnnaZivkovic wants to merge 4 commits intooutrigger-project:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@AnnaZivkovic: This pull request references MULTIARCH-5642 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AnnaZivkovic The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
AnnaZivkovic
force-pushed
the
remove-uporcessed-enee
branch
from
a12f2c0 to
05c078a
Compare
AnnaZivkovic
force-pushed
the
remove-uporcessed-enee
branch
from
05c078a to
b419949
Compare
…ng the CPPC or disabling the enoexecEvent plugin
The ENoExecEvent reconciler marks objects with error labels when theydon't have a pod name or are in the wrong namespace. This creates raceconditions in tests that create ENoExecEvents and then try to updatetheir status - the reconciler may have already modified the object,causing 409 Conflict errors.
AnnaZivkovic
force-pushed
the
remove-uporcessed-enee
branch
from
b419949 to
53082af
Compare
|
@AnnaZivkovic: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
In the ENoExecEvent reconciler it is possible that an error could occur which would result in the ENoExecEvent CR to not be deleted. During the uninstall/disabling of the execFormatErrorMontior plugin these left over CR will prevent the removal of the deployment.
When an ENoExecEvent fails to reconcile, it will now be labeled as an error. The cleanup logic for the execFormatErrorMontior will now bypass these errored CRs when the plugin is disabled, ensuring a clean shutdown. Disabling the ENoExecEvent plugin will remove all remaining ENoExecEvent resources, regardless of their state.