-
Notifications
You must be signed in to change notification settings - Fork 16
feat(guidelines): avoid digits in camelCase #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(guidelines): avoid digits in camelCase #99
Conversation
cgebken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor suggestions :) Great ADR!
api-guidelines/global/json/naming-conventions/rules/should-use-camel-case-for-property-names.md
Outdated
Show resolved
Hide resolved
api-guidelines/global/json/naming-conventions/rules/should-use-camel-case-for-property-names.md
Show resolved
Hide resolved
...uidelines/rest/resources/naming-conventions/rules/must-use-camelcase-for-query-parameters.md
Outdated
Show resolved
Hide resolved
...uidelines/rest/resources/naming-conventions/rules/must-use-camelcase-for-query-parameters.md
Show resolved
Hide resolved
…-camel-case-for-property-names.md Co-authored-by: Christina Framke <[email protected]>
Co-authored-by: Christina Framke <[email protected]>
…e-camelcase-for-query-parameters.md Co-authored-by: Christina Framke <[email protected]>
|
Feedback from the Async API Community: In general we agree on avoiding digits in camelCase. But we also thought about common abbreviations like B2B, B2C, and E2E, which are also used in our marketplace ecosystem. As we change the rule to “avoid digits” and not "disallow digits", this should be fine for such special cases. We should disallow leading digits in property names, as this could lead to compile errors in common programming languages like Java. |
Co-authored-by: Kiriakos Krastillis <[email protected]>
|
LGTM, after adding more examples for DOs and DON'Ts |
Changelog:
Update