-
Notifications
You must be signed in to change notification settings - Fork 80
Add avr-gcc@15 formula #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The build is currently failing for macOS Ventura due to a missing include. Currently, I don't have access to a machine with this version of macOS and, for some reason, I cannot get any of the macOS installers to work in UTM or Parallels. While I was able to reproduce this issue on macOS Monterey (on AArch64), I ran into even more compilation errors after fixing it. I'll try to get a working VM with macOS Ventura to debug this issue. |
a544797 to
f326ca8
Compare
|
It took me a while to get a working macOS Ventura VM, as the installer images provided by Apple still didn't seem to work. It seems that the missing include was the only issue that prevented this from compiling on macOS Ventura (at least on AArch64 with Xcode 14.3). I added a patch for the missing include; it is applied unconditionally, as it should not affect compilation on newer versions of macOS. Furthermore, I (re)ran the Homebrew checks on macOS Ventura and Sequoia. |
f326ca8 to
63b43ac
Compare
|
It seems that a gnu.org URL style check was reintroduced since I ran the checks: I fixed this for the GCC 15 formula by swapping mirror and main site URLs, however the build bot still fails on all other formulas with gnu.org URLs. I'm not sure what the best course of action is, here. |
63b43ac to
fe38f13
Compare
|
I updated the formula to GCC 15.2.0 and addressed recent Homebrew audit changes. This still requires the failing audit checks in the other formulas to be resolved. This was tested on macOS 15.6 (on AArch64) with Xcode 26.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new formula for AVR-GCC version 15 to support GCC 15.1.0 (though there's a version inconsistency that needs to be resolved). The formula is based on the existing avr-gcc@14 formula and incorporates patches from the Homebrew Core GCC 15.1.0 formula along with a custom patch to fix missing includes for macOS.
Key changes:
- New
[email protected]formula for GCC 15 with AVR target support - Custom patch file to fix missing
<algorithm>include in AVR-specific code - README updated to document the new formula
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| README.md | Added entry for GCC 15.2.0 (version number needs correction to match 15.1.0) |
| Patch/avr-gcc-15-fix-missing-include.patch | New patch to add missing include directive for std::min support on older macOS versions |
| Formula/[email protected] | New formula for AVR-GCC 15 with dependencies, build configuration, and tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
thanks a lot @davidstritzl for the PR! I'll take a look at the others first and when everything is fixed come back to this one. |
Signed-off-by: David Stritzl <[email protected]>
Signed-off-by: David Stritzl <[email protected]>
fe38f13 to
3a7e60e
Compare
|
The PR is rebased onto main and the patch was removed, as that was only necessary for macOS 13 and earlier. |
|
thanks a lot @davidstritzl ! |
This adds a new
avr-gcc@15formula for GCC 15.1.0. The formula is based on the formula for AVR-GCC 14.2.0 and the Homebrew Core formula for GCC 15.1.0. The latter also updates the GCC patches to the GCC 15.1.0 branch of the Darwin maintainer of GCC.The following Homebrew checks have been run successfully:
brew test ./Formula/[email protected],brew audit --strict avr-gcc@15andbrew style --fix ./Formula/[email protected].This has been tested on macOS 15.5 on AArch64 with Xcode 16.4. Some on-device tests have been done with a ATmega2560.
Furthermore, the README is updated to include the new formula.