Skip to content

fix: updates Baseline scan to show output on failure #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpower432 merged 1 commit into from
Jun 18, 2025
Merged

fix: updates Baseline scan to show output on failure #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/osps-baseline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ jobs:
TOKEN: ${{ steps.app-token.outputs.token }}

- name: Scan all repos
run: privateer run --binaries-path /.privateer/bin --config .github/config.yml
run: privateer run --binaries-path /.privateer/bin --config .github/config.yml > /dev/null 2>&1
Copy link

@marcusburghardt marcusburghardt May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be good to show possible execution errors or would this also be in the log files listed below?

Copy link
Member Author

@jpower432 jpower432 May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question! Based on my local testing, those appear in the log files.

Copy link

@marcusburghardt marcusburghardt May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. : ) Thanks for confirming.


- name: Print Result
if: success() || failure()
run: for file in evaluation_results/**/*.log; do echo $file; cat $file; echo; done
Loading