Include blockhash in /r/utxo response#4259
Open
lifofifoX wants to merge 9 commits intoordinals:masterfrom
Open
Include blockhash in /r/utxo response#4259lifofifoX wants to merge 9 commits intoordinals:masterfrom
lifofifoX wants to merge 9 commits intoordinals:masterfrom
Conversation
Contributor
|
This would be a great addition since with this we can also determine the remaining locktime of the assets locked with the methods in #4256 |
f7nine31a
reviewed
Mar 13, 2025
raphjaph
requested changes
Mar 25, 2025
Collaborator
raphjaph
left a comment
raphjaph
left a comment
There was a problem hiding this comment.
I like it, just some small things
Make `blockhash` a required field for `UtxoRecursive` struct
Collaborator
|
Could you add a test for this? |
casey
requested changes
May 16, 2025
src/index.rs
Outdated
| runes: self.get_rune_balances_for_output(outpoint)?, | ||
| sat_ranges: self.list(outpoint)?, | ||
| value: utxo_entry.value().parse(self).total_value(), | ||
| blockhash: tx_info.blockhash.unwrap(), |
Collaborator
There was a problem hiding this comment.
Under what circumstances will this unwrap panic?
Collaborator
Author
There was a problem hiding this comment.
It should never panic because this only gets called if there's an entry present in OUTPOINT_TO_UTXO_ENTRY.
Collaborator
Author
|
@raphjaph I updated the existing test to add coverage for this. Do you think this needs its own test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables recursive retrieval of a UTXO blockhash, allowing to determine how long an inscription has been held or when it was burned.