Skip to content

[GR-72687] Run GC only once the timeout exceeds 4s in Windows os_helper.py _waitfor to reduce overhead. #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
graalvmbot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[GR-72687] Run GC only once the timeout exceeds 4s in Windows os_helper.py _waitfor to reduce overhead. #619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions graalpython/lib-python/3/test/support/os_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,6 @@ def unlink(filename):

if sys.platform.startswith("win"):
def _waitfor(func, pathname, waitall=False):
# GraalPy change: run GC to ensure all handles are closed
support.gc_collect()
# Perform the operation
func(pathname)
# Now setup the wait loop
Expand All @@ -350,9 +348,7 @@ def _waitfor(func, pathname, waitall=False):
# required when contention occurs.
timeout = 0.001
# GraalPy change: increase timeout to account for our overloaded machines
# and run GC to ensure all handles are closed
while timeout < 120.0:
support.gc_collect()
# Note we are only testing for the existence of the file(s) in
# the contents of the directory regardless of any security or
# access rights. If we have made it this far, we have sufficient
Expand All @@ -366,6 +362,10 @@ def _waitfor(func, pathname, waitall=False):
# Increase the timeout and try again
time.sleep(timeout)
timeout *= 2
# GraalPy change: if we are this far, also run GC to ensure
# all handles are closed
if timeout > 4.0:
support.gc_collect()
warnings.warn('tests may fail, delete still pending for ' + pathname,
RuntimeWarning, stacklevel=4)

Expand Down
Loading