Skip to content

[GR-72687] Run GC in test support _unlink amd _rmdir on Windows to make sure all handles are closed & ignore problematic part of test_xml_etree.test_iterparse. #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graalvmbot merged 2 commits into from
Jan 26, 2026
Merged

[GR-72687] Run GC in test support _unlink amd _rmdir on Windows to make sure all handles are closed & ignore problematic part of test_xml_etree.test_iterparse. #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fa97c8
Run GC in test support _unlink amd _rmdir on Windows to make sure all…
steve-s Jan 26, 2026
38906bc
Temporarily ignore the problematic part of test_xml_etree.test_iterparse
steve-s Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions graalpython/lib-python/3/test/support/os_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,8 @@ def unlink(filename):

if sys.platform.startswith("win"):
def _waitfor(func, pathname, waitall=False):
# GraalPy change: run GC to ensure all handles are closed
support.gc_collect()
# Perform the operation
func(pathname)
# Now setup the wait loop
Expand All @@ -348,7 +350,9 @@ def _waitfor(func, pathname, waitall=False):
# required when contention occurs.
timeout = 0.001
# GraalPy change: increase timeout to account for our overloaded machines
# and run GC to ensure all handles are closed
while timeout < 120.0:
support.gc_collect()
# Note we are only testing for the existence of the file(s) in
# the contents of the directory regardless of any security or
# access rights. If we have made it this far, we have sufficient
Expand Down
7 changes: 4 additions & 3 deletions graalpython/lib-python/3/test/test_xml_etree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,9 +646,10 @@ def test_iterparse(self):
del cm, it

# Not exhausting the iterator still closes the resource (bpo-43292)
with warnings_helper.check_no_resource_warning(self):
it = iterparse(TESTFN)
del it
# GraalPy change: ignored, see GR-72687
#with warnings_helper.check_no_resource_warning(self):
# it = iterparse(TESTFN)
# del it

with self.assertRaises(FileNotFoundError):
iterparse("nonexistent")
Expand Down