Relaxed check of Request Object media type during uri scheme presentment #1499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidz25
approved these changes
Jan 14, 2026
Contributor
davidz25
left a comment
davidz25
left a comment
There was a problem hiding this comment.
LGTM but please include the DCO (Signed-off-by).
Contributor
Author
|
My bad, will update PR 🫡 |
Signed-off-by: Asgeir Hølleland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1292
Had this issue as well and figured I should try to fix it. Found that Ktor's ContentType has a
matchfunction that allows us to check for specific content type and content type subtype.