Add speaker embeddings support #3855
Open
+93
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkulakowski
changed the title
michalkulakowski
force-pushed
the
mkulakow/support_voice_embeddings
branch
from
ec35a1a to
4f45830
Compare
Collaborator
|
Can you include the unit tests? |
dkalinowski
reviewed
Jan 15, 2026
| TtsServable(const mediapipe::T2sCalculatorOptions& nodeOptions, const std::string& graphPath) { | ||
| auto fsModelsPath = std::filesystem::path(nodeOptions.models_path()); | ||
| TtsServable(const std::string& modelDir, const std::string& targetDevice, const google::protobuf::RepeatedPtrField<mediapipe::T2sCalculatorOptions_SpeakerEmbeddings>& graphVoices, const std::string& pluginConfig, const std::string& graphPath) { | ||
| auto fsModelsPath = std::filesystem::path(modelDir); |
Collaborator
There was a problem hiding this comment.
can you move this constructor to cpp? this way you could move read_speaker_embedding to cpp as well.
dkalinowski
reviewed
Jan 15, 2026
| input.seekg(0, std::ios::beg); | ||
|
|
||
| // Check size is multiple of float | ||
| OPENVINO_ASSERT(buffer_size % sizeof(float) == 0, "File size is not a multiple of float size."); |
Collaborator
There was a problem hiding this comment.
i think it might be the first time we use openvino_assert
why are we introducing yet another way of reporting errors?
for now we have:
- ovms::Status
- absl::Status
- std::variant<Obj, std::string(error)>
- and now this... :(
dkalinowski
reviewed
Jan 15, 2026
| for (auto voice : graphVoices) { | ||
| if (!std::filesystem::exists(voice.path())) | ||
| throw std::runtime_error{"Requested voice speaker embeddings file does not exist."}; | ||
| voices[voice.name()] = read_speaker_embedding(voice.path()); |
Collaborator
There was a problem hiding this comment.
do we catch exceptions thrown inside read_speaker_embedding?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``