-
Notifications
You must be signed in to change notification settings - Fork 336
feat:Supplement version logs and switch the drill site version. #3953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughVersion 3.28.0 changelog entries are added across documentation files with features and bug fixes documented. The runtime version in the playground application is bumped from 3.27 to 3.28, and the supported versions list is updated accordingly. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
examples/sites/demos/pc/webdoc/changelog-en.mdexamples/sites/demos/pc/webdoc/changelog.mdexamples/sites/playground/App.vue
🧰 Additional context used
🪛 LanguageTool
examples/sites/demos/pc/webdoc/changelog-en.md
[style] ~53-~53: Consider using a different verb for a more formal wording.
Context: ...com//pull/3813> - fix: fixed an issue where pipeline errors were cau...
(FIX_RESOLVE)
[style] ~56-~56: Consider using a different verb for a more formal wording.
Context: ...com//pull/3828> - fix: fixed an issue where icon-multicolor failed t...
(FIX_RESOLVE)
[grammar] ~79-~79: Ensure spelling is correct
Context: ... when deleting tabs in the mobile-first vue2 environment. by @discreted66 in <https:...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[style] ~168-~168: Consider using a different verb for a more formal wording.
Context: ...com//pull/3698> - fix: fix the issue of missing the tiny prefix in...
(FIX_RESOLVE)
[style] ~178-~178: Consider using a different verb for a more formal wording.
Context: .../tiny-vue/pull/3742> - fix: [tree-menu] fix the issue of icons not being referenced...
(FIX_RESOLVE)
[style] ~193-~193: Consider using a different verb for a more formal wording.
Context: ...tiny/tiny-vue/pull/3779> - fix(drawer): Fixed the problem that the table component in...
(FIX_RESOLVE)
[grammar] ~203-~203: Ensure spelling is correct
Context: ...eric modelValue type should not include underfined by @wuyiping0628 in <https://github.com...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~219-~219: Use a hyphen to join words.
Context: ...w Features 🎉 - feat(steps): Add wizard style step bar itemStyle differentiated ...
(QB_NEW_EN_HYPHEN)
[style] ~243-~243: Using “back” with the verb “return” may be redundant.
Context: ...id): grid promise validate return value back to undefined by @gimmyhehe in <https://...
(RETURN_BACK)
[style] ~259-~259: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ...y/tiny-vue/pull/3641> - fix(grid): grid can not validate on active by @gimmyhehe in <ht...
(CAN_NOT_PREMIUM)
[style] ~276-~276: Unless you want to emphasize “not”, use “cannot” which is more common.
Context: ... fix(grid): fix use title function text can not overflow ellipsis by @gimmyhehe in <htt...
(CAN_NOT_PREMIUM)
examples/sites/demos/pc/webdoc/changelog.md
[style] ~53-~53: Consider using a different verb for a more formal wording.
Context: ...com//pull/3813> - fix: fixed an issue where pipeline errors were cau...
(FIX_RESOLVE)
[style] ~56-~56: Consider using a different verb for a more formal wording.
Context: ...com//pull/3828> - fix: fixed an issue where icon-multicolor failed t...
(FIX_RESOLVE)
[grammar] ~79-~79: Ensure spelling is correct
Context: ... when deleting tabs in the mobile-first vue2 environment. by @discreted66 in <https:...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.18.1)
examples/sites/demos/pc/webdoc/changelog-en.md
131-131: Multiple headings with the same content
(MD024, no-duplicate-heading)
206-206: Multiple headings with the same content
(MD024, no-duplicate-heading)
215-215: Multiple headings with the same content
(MD024, no-duplicate-heading)
291-291: Multiple headings with the same content
(MD024, no-duplicate-heading)
🔇 Additional comments (3)
examples/sites/playground/App.vue (2)
18-18: LGTM! Version constant correctly updated.The VERSION constant has been properly updated to reference version 3.28, aligning with the PR's objective to switch the playground version.
29-29: LGTM! Versions list properly updated.The versions array correctly prioritizes 3.28 as the latest version, followed by 3.27 and 3.26, maintaining the three most recent versions as intended.
examples/sites/demos/pc/webdoc/changelog.md (1)
7-126: LGTM! Changelog for v3.28.0 properly documented.The new version section comprehensively documents features, bug fixes, and other changes for v3.28.0/v2.28.0, aligning with the PR's objective to supplement version logs.
| # 更新日志 | ||
|
|
||
| The Tiny Vue team uses a monthly release strategy under normal circumstances. | ||
| Tiny Vue 团队在正常情况下使用 每月 发布策略。 | ||
|
|
||
| On this page, you can only see the log records of the latest three iterations of our changelog. If you want to see the full record, you can view: [Release](https://github.com/opentiny/tiny-vue/releases) | ||
| 在此页面上,您只能看到我们的 更新日志 最新三个迭代的日志记录,如您要查看完整记录可以查看:[Release](https://github.com/opentiny/tiny-vue/releases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File naming inconsistency: "-en" suffix but Chinese content.
The filename changelog-en.md suggests English localization (the "-en" suffix conventionally indicates English), but the content is in Chinese ("更新日志", "Tiny Vue 团队在正常情况下使用 每月 发布策略。"). This creates confusion about language versions.
Please clarify:
- Is this file intended to be the English version that needs translation?
- Should this file be renamed to remove the "-en" suffix?
- Or is there a separate English changelog file elsewhere?
🤖 Prompt for AI Agents
In examples/sites/demos/pc/webdoc/changelog-en.md lines 1-5, the filename uses
the "-en" English suffix but the content is Chinese; decide which is intended
and fix accordingly: if this should be the English version, translate the
Chinese content into English and keep the filename; if it is meant to be the
Chinese version, rename the file to remove or replace the "-en" suffix (e.g.,
changelog.md or changelog-zh.md) and update any links/navigation that reference
changelog-en.md; alternatively, if a separate English changelog exists, move
this content to the correct Chinese file and ensure the English file contains
the English text — update repository references and docs indexes accordingly.
PR
feat:补充版本日志,切换演练场版本
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.