Skip to content

Conversation

@open-junius
Copy link
Contributor

@open-junius open-junius commented Dec 12, 2025

Description

The changes in the PR include:

  1. set the retry times as 5
  2. set the network registration cost as constant, avoid cost spike for continuous registration
  3. add sleep time for some contract transaction. avoid these not handled by runtime with error "already known".
  4. use ccx43 configuration to avoid process exit during testing.
  5. start 5 local nodes to verify mev implementation.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius self-assigned this Dec 12, 2025
@open-junius open-junius added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Dec 15, 2025
@open-junius open-junius changed the title try single node test use single node for contract test Dec 15, 2025
@open-junius open-junius requested a review from ales-otf December 16, 2025 12:11
@sam0x17
Copy link
Contributor

sam0x17 commented Jan 22, 2026

What was the reason for using a single node? Reason I ask is we were actually just thinking of increasing to 5 or so for e2e because mev shield has some edge cases that are only caught with an odd number of validators greater than 4

@open-junius
Copy link
Contributor Author

Just try to decrease the resource usage. Recently, I found out the process can't start or exit during e2e testing. If the e2e test can help with mev issue, then it makes sense to continue with two nodes testing. I will revert it to previous one, and optimize the process, make it easier to get what wrong during testing.

@open-junius open-junius changed the title use single node for contract test optimize contract test process Jan 22, 2026
@open-junius open-junius marked this pull request as draft January 23, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants