fix: key_management skip decrypt_sdk js v0.2.0

[pflynn-virtru]

This pull request makes minor improvements to the ABAC test suite by ensuring that tests are only run when the required key management feature is supported by both the encryption and decryption SDKs. This helps prevent unnecessary test failures when running on unsupported platforms.

Test robustness improvements:

• Added a call to tdfs.skip_if_unsupported(decrypt_sdk, "key_management") in test_import_legacy_golden_r1_key_and_decrypt_no_split to skip the test if the decrypt SDK does not support key management.
• Added a call to tdfs.skip_if_unsupported(decrypt_sdk, "key_management") in test_encrypt_decrypt_all_containers_with_base_key_e1 for the same reason.

[gemini-code-assist]

Summary of Changes

Hello @pflynn-virtru, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the stability and reliability of the ABAC test suite. By introducing conditional skipping for tests that rely on key management features, it ensures that tests are only executed in environments where the necessary SDK capabilities are present. This refinement prevents irrelevant test failures and provides clearer feedback on actual regressions.

Highlights

• Test Robustness: Improved the ABAC test suite by adding checks to skip tests when the required key management feature is not supported by the decryption SDK, preventing unnecessary failures on unsupported platforms.
• Conditional Test Skipping: Introduced tdfs.skip_if_unsupported(decrypt_sdk, "key_management") calls in test_import_legacy_golden_r1_key_and_decrypt_no_split and test_encrypt_decrypt_all_containers_with_base_key_e1 to ensure tests only run with appropriate SDK support.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[gemini-code-assist]

Code Review

This pull request correctly adds checks to skip tests when the key_management feature is not supported, which improves the robustness of the test suite. The changes are logical and follow the pull request's objective. I have one suggestion to refactor a small portion of the code to improve efficiency by avoiding redundant object initializations.

[gemini-code-assist]

This change is functionally correct, but it introduces some inefficiency. The skip_if_unsupported function initializes a PlatformFeatureSet on each call, and then it's initialized again explicitly on line 850. This results in it being created three times in this test setup.

To make this more efficient and the code cleaner, you can initialize PlatformFeatureSet just once and then perform the checks directly. This avoids the repeated overhead of creating the PlatformFeatureSet object.

Suggested change

	tdfs.skip_if_unsupported(encrypt_sdk, "key_management")
	tdfs.skip_if_unsupported(decrypt_sdk, "key_management")
	pfs = tdfs.PlatformFeatureSet()
	pfs = tdfs.PlatformFeatureSet()
	feature = "key_management"
	if feature not in pfs.features:
	pytest.skip(f"platform service {pfs.version} doesn't yet support [{feature}]")
	if not encrypt_sdk.supports(feature):
	pytest.skip(f"{encrypt_sdk} sdk doesn't yet support [{feature}]")
	if not decrypt_sdk.supports(feature):
	pytest.skip(f"{decrypt_sdk} sdk doesn't yet support [{feature}]")

[github-actions]

X-Test Results

✅ go-v0.4.34
✅ js-v0.4.34
✅ java-v0.4.34
✅ js-main
✅ go-main
✅ java-main