-
Notifications
You must be signed in to change notification settings - Fork 24
fix!: remove nanotdf support #3013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @strantalis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring effort to entirely deprecate and remove NanoTDF support from the project. The primary goal is to simplify the architecture and maintenance burden by concentrating all development efforts on the standard TDF format. This change impacts various layers, from low-level cryptographic utilities to user-facing command-line tools and documentation, ensuring a consistent and unified approach to data protection. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Old code, once bright, Now fades from memory's sight, New paths, clean and light. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively removes all support for nanotdf from the codebase. The changes are comprehensive, touching documentation, examples, tests, and core SDK and service logic. The removal of nanotdf-specific code paths simplifies many areas, and the renaming of concepts from nanotdf to more generic terms like EC-based is a good improvement for clarity. The PR is well-executed and I have no further suggestions.
|
as stated via the |
Remove NanoTDF implementation and references from SDK, examples, and KAS. Regenerates grpc/openapi/proto outputs. Signed-off-by: strantalis <[email protected]>
Update benchmark-bulk CI invocation after removing the --tdf flag. Signed-off-by: strantalis <[email protected]>
Avoid yq env(ROOT_KEY) evaluation when key_management is false in start-additional-kas. Signed-off-by: strantalis <[email protected]>
e280f3c to
d452b76
Compare
Proposed Changes
Checklist
Testing Instructions