Show resource popup on marker click and remove duplicate resource link option in the admin server #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k option in the admin server
ferhany
requested review from
OscarBakker and
rudivanhierden
and removed request for
a team
Openstad Headless
|
||||||||||||||||||||||||||||
| Project |
Openstad Headless
|
| Branch Review |
fix/marker-onclick-resource-popup
|
| Run status |
|
| Run duration | 21m 28s |
| Commit |
|
| Committer | ferhany |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
51
|
| View all changes introduced in this branch ↗︎ | |
Contributor
|
@ferhany can you check the api-server build errors? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the marker click function for the resource overview widget, so that a click on a marker on the map leads to a resource dialog popping up (if the widget setting is selected for this to happen)
It also removes a duplicate setting for the URL of a tile/marker. Previously, the markers on the map and the tiles on the resource overview had a separate setting for the urls they should lead to. This was changed in this PR so that now you only have one setting that changes both the tiles and the marker's urls. This was done because the setting for the markers is excessive, as the tiles and the markers will (as far as we can tell) always have the same url.