Skip to content

Conversation

@OscarBakker
Copy link
Contributor

No description provided.

@OscarBakker OscarBakker requested review from a team as code owners January 9, 2026 18:15
@OscarBakker OscarBakker requested review from IanR01 and iandebruin98 and removed request for a team January 9, 2026 18:15
@cypress
Copy link

cypress bot commented Jan 9, 2026

Openstad Headless    Run #1264

Run Properties:  status check passed Passed #1264  •  git commit 4a51cbd49c ℹ️: Merge d946f1969ea2eb18f6c2576c1abe341b3108ede5 into 256233d959f3e35cf2777ff16164...
Project Openstad Headless
Branch Review OP-589/url-naar-gebruikersonderzoek-kunnen-toevoegen-begrootmodule-upstream
Run status status check passed Passed #1264
Run duration 21m 35s
Commit git commit 4a51cbd49c ℹ️: Merge d946f1969ea2eb18f6c2576c1abe341b3108ede5 into 256233d959f3e35cf2777ff16164...
Committer Oscar
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 51
View all changes introduced in this branch ↗︎

Copy link
Contributor

@rudivanhierden rudivanhierden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the admin-server configuration so a Rich Text Editor is used for these properties like introText? This ensures the user can use the editor to format the text correctly. By then using the rte-formatting package we give the user more flexibility, while staying within the NLDesign elements.

<div className="stem-begroot-budget-list-used-budgets">
<div className="stem-begroot-helptext-and-budget-section-helptext">
<Paragraph>{introText}</Paragraph>
<div dangerouslySetInnerHTML={{ __html: introText }} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the RenderContent method from the rte-formatting package? This allows us to transform the HTML to NLDesign elements

import RenderContent from '../../../ui/src/rte-formatting/rte-formatting'

// ...
return (
  <div className="rte" dangerouslySetInnerHTML={{ __html: RenderContent(content) }} />
)

@ferhany ferhany linked an issue Jan 28, 2026 that may be closed by this pull request
@OscarBakker
Copy link
Contributor Author

Can you change the admin-server configuration so a Rich Text Editor is used for these properties like introText? This ensures the user can use the editor to format the text correctly. By then using the rte-formatting package we give the user more flexibility, while staying within the NLDesign elements.

added the rte formatting. A richt text editor will be added later. First need to counsel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve begrootmodule

3 participants