Skip to content

Conversation

@ImFelipeOliveira
Copy link

Description

Added configurable maximum header length for commit messages.

Related Issue

[If your pull request is related to an existing issue, reference it here using the format "Fixes #issue_number".]

Type of Change

Please mark the appropriate option below to describe the type of change your pull request introduces:

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Refactor
  • Other (please specify)

Checklist

  • My pull request has a clear title and description.
  • I have used semantic commit messages.
    Examples: "fix: Fixed foobar bug", "feat(accounts): Added foobar feature".
  • I have added/updated the necessary documentation on README.md.
  • I have added appropriate test cases (if applicable) to ensure the changes are functioning correctly.

Additional Notes

[Add any additional notes or context that you think the reviewers should know about.]

By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.

@aj3sh aj3sh requested review from aj3sh and sugat009 November 9, 2025 03:15
Copy link
Member

@aj3sh aj3sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ImFelipeOliveira, thank you for the contribution! I really appreciate the work you’ve done here. However, a few things are missing, and I’ve pointed them out.

default: 'false'
default: "false"
required: false
max_header_length:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inputs are not loaded directly to commitlint from github actions. Here are the steps:

  1. Add input in the inputs section of action.yml. (Already done)

  2. Load it as an env variable, at the end of the file at "Commitlint Action" step.

  3. Use the env variable at github_actions/action/run.py to add it as an argument. (you can take reference from INPUT_VERBOSE).

  4. Load the args to the config on src/commitlint/cli.py::main (reference config.verbose = args.verbose). Make sure to handle the optional case 🙂.

  5. Update the README.md regarding the GitHub Actions input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants