OCM-22843 | fix: add channel flag in the prompt message for creation in future#3224
Open
yuwang-RH wants to merge 1 commit intoopenshift:masterfrom
Open
OCM-22843 | fix: add channel flag in the prompt message for creation in future#3224yuwang-RH wants to merge 1 commit intoopenshift:masterfrom
yuwang-RH wants to merge 1 commit intoopenshift:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwang-RH The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
@yuwang-RH: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message of "To create this cluster again in the future" should contain '--channel' if it is set during cluster creation.
With fix, if users setting '--channel' or setting channel in the interactive mode, the prompt message contains the channel key and value as they set.
Log is as bellow
I: To create this cluster again in the future, you can run: rosa create cluster --cluster-name yuwan0320hu4-wv .... --version 4.20.15 --channel stable-4.20 ....