Skip to content

tide: require CodeQL checks for ARO-HCP#76488

Open
hlipsig wants to merge 1 commit intoopenshift:mainfrom
hlipsig:hlipsig/tide-require-codeql-arohcp
Open

tide: require CodeQL checks for ARO-HCP#76488
hlipsig wants to merge 1 commit intoopenshift:mainfrom
hlipsig:hlipsig/tide-require-codeql-arohcp

Conversation

@hlipsig
Copy link

@hlipsig hlipsig commented Mar 18, 2026

This should correctly block PRs from merging where CodeQL fails.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@openshift-ci openshift-ci bot requested review from hector-vido and psalajova March 18, 2026 20:56
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2026
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 18, 2026
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@hlipsig: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

@hlipsig: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mmazur
Copy link
Member

mmazur commented Mar 18, 2026

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hlipsig, mmazur, stevekuznetsov
Once this PR has been reviewed and has the lgtm label, please assign danilo-gemoli for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants