-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OCPBUGS#37577: Add a note about identity-provider-arn #109594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aksjoshi89
wants to merge
1
commit into
openshift:enterprise-4.15
Choose a base branch
from
aksjoshi89:OCPBUGS-37577
base: enterprise-4.15
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,13 +6,19 @@ include::_attributes/common-attributes.adoc[] | |
|
|
||
| toc::[] | ||
|
|
||
| [role="_abstract"] | ||
| The {cert-manager-operator} is not installed in {product-title} by default. You can install the {cert-manager-operator} by using the web console. | ||
|
|
||
| [NOTE] | ||
| ==== | ||
| The operator sets `features.operators.openshift.io/token-auth-aws`, `features.operators.openshift.io/token-auth-azure`, `features.operators.openshift.io/token-auth-gcp` annotations in the operator CSV, and console asks to provide the relevant credentials details when these annotations are set. Currently, the operator does not make use of the values collected by the console and users should follow https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/security_and_compliance/cert-manager-operator-for-red-hat-openshift. Users can provide any dummy value when asked for the input. For example, when installing on ROSA, the `identity-provider-arn` is asked and any value can be provided to proceed. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The text is not enclosed in a Note or Important block. Also in the preview I see the initial intro text appearing twice could you please check. |
||
| ==== | ||
|
|
||
| [IMPORTANT] | ||
| ==== | ||
| The {cert-manager-operator} version 1.15 or later supports the `AllNamespaces`, `SingleNamespace`, and `OwnNamespace` installation modes. Earlier versions, such as 1.14, support only the `SingleNamespace` and `OwnNamespace` installation modes. | ||
| ==== | ||
|
|
||
| The {cert-manager-operator} is not installed in {product-title} by default. You can install the {cert-manager-operator} by using the web console. | ||
|
|
||
| == Installing the {cert-manager-operator} | ||
| // Installing the {cert-manager-operator} using the web console | ||
| include::modules/cert-manager-install-console.adoc[leveloffset=+2] | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] Vale.Terms: Use 'Operators?' instead of 'operator'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/security_and_compliance/cert-manager-operator-for-red-hat-openshift
https://docs.redhat.com/en/documentation/openshift_container_platform/{product-version}/html/security_and_compliance/cert-manager-operator-for-red-hat-openshift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ROSA, use an attribute provided in the common-attributes.adoc file: {product-rosa}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link syntax is not correct. Should be xref:../../security/cert_manager_operator/index.adoc#cert-manager-operator-about[OpenShift cert-manager Operator]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link might need to be moved to an additional resources section.