-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSDOCS-18757#LSO Symlinks updating #109365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lpettyjo
wants to merge
1
commit into
openshift:main
Choose a base branch
from
lpettyjo:OSDOCS-18757
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // * storage/persistent_storage/persistent-storage-local.adoc | ||
|
|
||
| :_mod-docs-content-type: CONCEPT | ||
| [id="local-storage-symlinks_{context}"] | ||
| = Local Storage Operator symlinks overview | ||
|
|
||
| [role="_abstract"] | ||
| The Local Storage Operator (LSO) traditionally creates persistent volumes (PVs) based on `/dev/disk/by-id/` paths, following the assumption that they are stable. However, Linux kernel updates, firmware updates, or `udev` rule changes can cause these supposedly stable names to change or disappear. | ||
|
|
||
| == Administrator options | ||
| Administrators have the following notification and correction options to deal with symlink disruptions: | ||
|
|
||
| * *Monitoring*: (default) If the current and preferred path do not match, an alerts occurs, but no changes occur to the current path. | ||
|
|
||
| * *Use existing path*: Alerts are silenced and LSO uses the existing path. | ||
|
|
||
| * *Recreate symlinks*: Symlinks are recreated to point to the new, updated device path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // * storage/persistent_storage/persistent-storage-local.adoc | ||
|
|
||
| :_mod-docs-content-type: PROCEDURE | ||
| [id="local-storage-symlinks-procedure_{context}"] | ||
| = Selecting symlinks management options for the Local Storage Operator | ||
|
|
||
| [role="_abstract"] | ||
| To prevent storage breakage during {product-title} upgrades, an administrator can elect to detect, alert, and remap broken symlinks without manual node-level intervention. | ||
|
|
||
| .Prerequisites | ||
|
|
||
| * Access to the {product-title} web console or command-line interface (CLI) with administrative privileges. | ||
|
|
||
| * Install the Local Storage Operator (LSO). See the _Installing the Local Storage Operator_ section. | ||
|
|
||
| .Procedure | ||
|
|
||
| . Log in to the {product-title} web console. | ||
|
|
||
| . Do not change the default setting (none) for `localVolumeDeviceLink.spec.policy`. | ||
| + | ||
| This establishes link monitoring and generates an alert if the current and preferred paths do not match. | ||
|
|
||
| . If an alert occurs, go to the Custom Resource Definition, `localVolumeDeviceLink`: | ||
|
|
||
| .. Click *Administration* > *CustomResourcesDefinitions*. | ||
|
|
||
| .. On the *CustomResourceDefinitions* page, in the *Filter by name* box, type "LocalVolumeDeviceLink". | ||
|
|
||
| .. Click *CustomResourceDefinitions*. | ||
|
|
||
| .. On the *CustomResourceDefinitions* page, click the *YAML* tab. | ||
|
|
||
| .. Navigate to `localVolumeDeviceLink.status` and view its nested fields that are shown in the following table for a list of valid symlink targets, current link (`by-id)`, and the generated preferred symlink. | ||
| + | ||
| .`localVolumeDeviceLink.status` nested fields | ||
| [width="100%", cols="autowidth", options="header"] | ||
| |=== | ||
| | Status fields |Description | ||
| | validLinkTargets |The full list of valid symlink targets, since there might be multiple `by-id` symlinks pointing to the same physical device. | ||
| | currentLinkTarget |The by-id symlink currently used by the PV. | ||
| | preferredLinkTarget |The preferred symlink chosen by diskmaker. | ||
| | filesystemUUID |The corresponding UUID of the filesystem, if one is found. | ||
| |=== | ||
|
|
||
| .. Navigate to `localVolumeDeviceLink.spec.policy` field and set its value to one of the following options: | ||
| + | ||
| * `CurrentLinkTarget`: Silences alerts and tells LSO to use the existing path. | ||
|
|
||
| * `PreferredLinkTarget`: LSO recreates the symlink to point to the new, updated device path. | ||
|
|
||
| . Click *Save*. | ||
|
|
||
| . Set `localVolumeDeviceLink.spec.policy` back to null. | ||
| + | ||
| This re-establishes link monitoring for future link disruptions, and generates an alert if the current and preferred paths do not match. | ||
|
|
||
| . Click *Save*. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| // Module included in the following assemblies: | ||
| // | ||
| // * storage/persistent_storage/persistent-storage-local.adoc | ||
|
|
||
| :_mod-docs-content-type: CONCEPT | ||
| [id="local-storage-symlinks-top-level_{context}"] | ||
| = Local Storage Operator symlinks management | ||
|
|
||
| [role="_abstract"] | ||
| To prevent storage breakage during {product-title} upgrades, {product-title} provides a mechanism, the `LocalVolumeDeviceLink` Custom Resource Definition, to detect, alert, and remap broken symlinks without manual node-level intervention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This procedure is odd. "Do nothing and this establishes link monitoring and generates an alert"
We should note that by default, LSO generates an alert when it detects that a PersistentVolume uses sub-optimal by-id symlink for a device. And then what to do with it, that part looks good.