OSDOCS Specify that user-created machinesets should use the latest bootimages#109278
OSDOCS Specify that user-created machinesets should use the latest bootimages#109278mburke5678 wants to merge 12 commits intoopenshift:mainfrom
Conversation
|
🤖 Thu Apr 09 17:36:09 - Prow CI generated the docs preview: |
|
/retest |
modules/machineset-yaml-vsphere.adoc
Outdated
| `<disk_name>`:: Specifies one or more data disk definitions. For more information, see "Configuring data disks by using machine sets". | ||
| `<image_name>`:: Specifies the image to use as a boot image for your nodes. You should use the use the latest image when adding a new machine set. | ||
| `<vm_network_name>`:: Specifies the vSphere VM network to deploy the compute machine set to. This VM network must be where other compute machines reside in the cluster. | ||
| `<vm_template_name>`:: Specifies the vSphere VM template to use, such as `user-5ddjd-rhcos`. |
There was a problem hiding this comment.
vsphere uses template field, there is no image field
There was a problem hiding this comment.
<vm_template_name>:: Specifies the vSphere VM template to use as a boot image for your nodes, such as user-5ddjd-rhcos. You should use a template with the latest {product-title} image when adding a new machine set.
| <3> Specify the node label to add. | ||
| <4> Edit the `checksum` URL to use the API VIP address. | ||
| <5> Edit the `url` URL to use the API VIP address. | ||
| <4> Specify the image details of the boot image for your nodes. You should use the latest image when adding a new machine set. |
There was a problem hiding this comment.
We should ask them to migrate to the new system for baremetal(#109158) than do this, since it is a one time action. This is referencing the old <4.9, presumably because the docs are out of date?
There was a problem hiding this comment.
When creating a bare metal machine set, you do not need to specify a boot image? The CVO takes care of this for new machines?
As for what is outdated, is it the whole stanza or just the <4> and <5>?
image: <4>
checksum: http:/172.22.0.3:6181/images/rhcos-<version>.<architecture>.qcow2.<md5sum> <5>
url: http://172.22.0.3:6181/images/rhcos-<version>.<architecture>.qcow2 <6>
It appears the example was added around the time when 4.12 was the current release. So it could be dated.
machine_management/index.adoc
Outdated
|
|
||
| [NOTE] | ||
| ==== | ||
| When creating a new machine set, you should specify the latest image to use for the boot image. The method to specify the image varies by provider. |
There was a problem hiding this comment.
| When creating a new machine set, you should specify the latest image to use for the boot image. The method to specify the image varies by provider. | |
| When creating a new machine set, you should specify the latest image to use for the boot image. For more info about updating the bootimage on your cluster, please refer to "Boot image management". The method to update or specify the image varies by provider. |
I did not see the preview for this, but perhaps it would be helpful to provide a reference about boot image updates here, so they can figure out if their cluster is even updated, and if it is, they can just copy of an existing machineset.
There was a problem hiding this comment.
Link to preview: Managing compute machines
366ddc9 to
ba4b183
Compare
ba4b183 to
72611dd
Compare
|
|
||
| [NOTE] | ||
| ==== | ||
| When creating a new machine set, you should specify the latest image to use for the boot image. For more information about updating the boot image on your cluster, see "Manually updating the boot image". The method to update or specify the image varies by platform. |
There was a problem hiding this comment.
| When creating a new machine set, you should specify the latest image to use for the boot image. For more information about updating the boot image on your cluster, see "Manually updating the boot image". The method to update or specify the image varies by platform. | |
| When creating a new machine set, you should specify the latest image to use for the boot image. For more information about updating the boot image on your cluster, see "Manually updating the boot image" and "Boot image management". The method to update or specify the image varies by platform. |
just adding a ref here
|
lgtm! |
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| |=== | ||
|
|
||
| For all other platforms, the MCO does not update the boot image with each cluster update. | ||
| For all other platforms, the MCO does not automatically update the boot image with each cluster update. For clusters where automatic updates are disabled or not supported, you can manually update the boot image on your cluster. See "Manually updating the boot image" for information. The method to update or specify the image varies by platform. |
There was a problem hiding this comment.
Is there already a link to "Manually updating the boot image" in additional resources?
https://redhat.atlassian.net/browse/OSDOCS-18752
Link to docs preview:
Overview of machine management -> Compute machine management -- Added note at end of section and link.
Standard machine sets:
Sample YAML for a compute machine set custom resource on AWS
Sample YAML for a compute machine set custom resource on Azure
Sample YAML for a compute machine set custom resource on Azure Stack Hub
Sample YAML for a compute machine set custom resource on Google Cloud
Sample YAML for a compute machine set custom resource on IBM Cloud
Sample YAML for a compute machine set custom resource on IBM Power Virtual Server
Sample YAML for a compute machine set custom resource on Nutanix
Sample YAML for a compute machine set custom resource on OpenStack
Sample YAML for a compute machine set custom resource that uses SR-IOV on RHOSP
Sample YAML for a compute machine set custom resource on vSphere
Sample YAML for a compute machine set custom resource on bare metal
Infrastructure machine sets:
Sample YAML for a compute machine set custom resource on AWS
Sample YAML for a compute machine set custom resource on Azure
Sample YAML for a compute machine set custom resource on Azure Stack Hub
Sample YAML for a compute machine set custom resource on IBM Cloud
Sample YAML for a compute machine set custom resource on Google Cloud
Sample YAML for a compute machine set custom resource on Nutanix
Sample YAML for a compute machine set custom resource on RHOSP
Sample YAML for a compute machine set custom resource on vSphere
Machine configuration -> Manually updating the boot image -> Manually updating the boot image on a Nutanix cluster -- Added boot image skew enforcement wording, as last step in the procedure, right before the verification.
Machine configuration -> Manually updating the boot image -> Manually updating the boot image on an RHOSP cluster -- Added boot image skew enforcement wording, as last step in the procedure, right before the verification.
QE review: