CNF-21106: main: Downstream only: Fix broken downstream bundle

[andreaskaris]

The downstream bundle was missing this critical new parameter. Given
that disableMP is completely ignored now by both FRRK8s and by metallb's
built-in FRR, and given that dualStackAddressFamily always defaults to
false, dualStack AF setups were no longer possible in OpenShift.
Adding the parameter to the CRD fixes this issue.

Is this a BUG FIX or a FEATURE ?:

/kind bug

Uncomment only one, leave it on its own line:

/kind bug
/kind cleanup
/kind feature
/kind design
/kind flake
/kind failing
/kind documentation
/kind regression

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

[openshift-ci-robot]

@andreaskaris: This pull request references CNF-21106 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

downstream bundle generation was broken because of commit 4db50df which introduced unresolved
conflict markers into file
prometheus-k8s_rbac.authorization.k8s.io_v1_rolebinding.yaml. That file's no longer needed, alongside a bunch of other files. In order to fix this:
rm -f bundle/manifests/*
make bundle
make bundle-release

Is this a BUG FIX or a FEATURE ?:

/kind bug

Uncomment only one, leave it on its own line:

/kind bug
/kind cleanup
/kind feature
/kind design
/kind flake
/kind failing
/kind documentation
/kind regression

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@andreaskaris: This pull request references CNF-21106 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The downstream bundle was missing this critical new parameter. Given
that disableMP is completely ignored now by both FRRK8s and by metallb's
built-in FRR, and given that dualStackAddressFamily always defaults to
false, dualStack AF setups were no longer possible in OpenShift.
Adding the parameter to the CRD fixes this issue.

Is this a BUG FIX or a FEATURE ?:

/kind bug

Uncomment only one, leave it on its own line:

/kind bug
/kind cleanup
/kind feature
/kind design
/kind flake
/kind failing
/kind documentation
/kind regression

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@andreaskaris: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[andreaskaris]

@oribon

[karampok]

/lgtm

[fedepaol]

/approve
/verified by ci

[openshift-ci-robot]

@fedepaol: This PR has been marked as verified by ci.

Details

In response to this:

/approve
/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreaskaris, fedepaol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [fedepaol]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andreaskaris]

/cherry-pick release-4.23

[openshift-cherrypick-robot]

@andreaskaris: new pull request could not be created: failed to create pull request against openshift/metallb-operator#release-4.23 from head openshift-cherrypick-robot:cherry-pick-301-to-release-4.23: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.23 and openshift-cherrypick-robot:cherry-pick-301-to-release-4.23"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherry-pick release-4.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[andreaskaris]

/cherry-pick release-4.21

[openshift-cherrypick-robot]

@andreaskaris: new pull request created: #311

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.