-
Notifications
You must be signed in to change notification settings - Fork 52
Release 4.19 #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hlipsig
wants to merge
50
commits into
main
Choose a base branch
from
release-4.19
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release 4.19 #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…55-to-release-4.18 [release-4.18] Refactor aro-dnsmasq-pre.sh to not overwrite /etc/resolv.conf
…63-to-release-4.18 [release-4.18] dnsmasq.conf: remove strict-order and add dns-forward-max
Merge main into 4.18
OpenShift 4.18
…24-to-release-4.18 [release-4.18] [ARO-20321] Don't check for availability zones in bad regions (like centraluseuap)
…16-to-release-4.18 [release-4.18] ARO-14269 Fluentbit update to latest support version 4.0.4
OpenShift 4.19
…45-to-release-4.19 [release-4.19] Add red-hat-managed: true tag to install-config
…nePool.identity.type
…faultMachinePool.identity.type set DefaultMachinePlatform in install-config.yaml
[ARO-4330] Add BootDiagnostics configuration to install config (4.19+)
This reverts commit 326633f.
…a770ce9a3a9a4d3cec4edd7badd26b10a665f18c [release-4.19] Revert "Add red-hat-managed: true tag to install-config"
Split image configuration into granular build args for better flexibility: Builder image args: - BUILDER_REGISTRY (default: registry.ci.openshift.org) - BUILDER_REPOSITORY (default: ocp/builder) - BUILDER_TAG (default: rhel-9-golang-1.24-openshift-4.20) Base image args: - REGISTRY (default: registry.access.redhat.com) - REPOSITORY (default: ubi9/ubi-minimal) - TAG (default: latest) This allows customizing individual components (registry, repository, or tag) without modifying the Dockerfile, making it more flexible for different environments (e.g., using MCR images for OneBranch pipelines). Defaults maintain existing behavior.
…59-to-release-4.19 [release-4.19] Make builder and base images configurable via build args
Switch RHCOS image default from Gen1 (aro_419) to Gen2 (419-v2) for improvedperformance and security features. Fallback to Gen1 only when either master or worker SKU does not support HyperV Generation V2. Fixes deployment error: "The selected VM size cannot boot Hypervisor Generation '1'." Fixes ARO-22037 Signed-off-by: Yadnesh Kulkarni <[email protected]>
Change the HyperV generation image selection logic to default to Gen1 images (aro_419) instead of Gen2 (419-v2). Gen2 images are now only used when a VM SKU exclusively supports V2 and does not support V1. Fixes ARO-22037 Signed-off-by: Yadnesh Kulkarni <[email protected]>
Signed-off-by: Yadnesh Kulkarni <[email protected]>
Use Gen1 VM images by default, switch to Gen2 only when required
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hlipsig The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.