HIVE-3114: Azure MachinePool: Increase timeout for ListImagesByResourceGroup()

[2uasimojo]

We've started seeing consistent timeouts in the field for this call, resulting in very slow response time for the MachinePool controller to lay down MachineSets for Azure spokes. Increase the timeout from 30s to 2m.

Summary by CodeRabbit

Bug Fixes

• Extended timeout for Azure image retrieval operations to prevent premature cancellation during resource enumeration, improving reliability and reducing operational failures.

[openshift-ci-robot]

@2uasimojo: This pull request references HIVE-3114 which is a valid jira issue.

Details

In response to this:

We've started seeing consistent timeouts in the field for this call, resulting in very slow response time for the MachinePool controller to lay down MachineSets for Azure spokes. Increase the timeout from 30s to 2m.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[2uasimojo]

/assign @suhanime
/cc @patrickdillon

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5c21f5d1-9ef5-4eae-a476-5a93e341cff7

📥 Commits

Reviewing files that changed from the base of the PR and between 366515c and 0c719f6.

📒 Files selected for processing (1)

• pkg/controller/machinepool/azureactuator.go

---

📝 Walkthrough

Walkthrough

A single timeout value is increased from 30 seconds to 2 minutes for the AzureActuator's ListImagesByResourceGroup paging operation. This is a straightforward configuration adjustment affecting one line of code with no functional or structural modifications.

Changes

Cohort / File(s)	Summary
Timeout Configuration pkg/controller/machinepool/azureactuator.go	Increased context timeout for AzureActuator.getImagesByResourceGroup from 30 seconds to 2 minutes, extending the cancellation window for the ListImagesByResourceGroup paging loop.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hop, hop! Two minutes now to dance,
Thirty seconds wasn't quite the chance,
Azure images need time to play—
A gentle timeout lights the way! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: increasing the timeout for ListImagesByResourceGroup() in Azure MachinePool, directly matching the changeset's single modification.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [2uasimojo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@2uasimojo: This pull request references HIVE-3114 which is a valid jira issue.

Details

In response to this:

We've started seeing consistent timeouts in the field for this call, resulting in very slow response time for the MachinePool controller to lay down MachineSets for Azure spokes. Increase the timeout from 30s to 2m.

Summary by CodeRabbit

Bug Fixes

• Extended timeout for Azure image retrieval operations to prevent premature cancellation during resource enumeration, improving reliability and reducing operational failures.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.30%. Comparing base (366515c) to head (0c719f6).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2874   +/-   ##
=======================================
  Coverage   50.30%   50.30%           
=======================================
  Files         280      280           
  Lines       34310    34310           
=======================================
  Hits        17259    17259           
  Misses      15690    15690           
  Partials     1361     1361           

Files with missing lines	Coverage Δ
pkg/controller/machinepool/azureactuator.go	73.17% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[2uasimojo]

/test e2e-azure

[2uasimojo]

@2uasimojo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 0c719f6 link true /test e2e-azure
Full PR test history. Your PR dashboard.

Details

Should be resolved by openshift/release#76389

[2uasimojo]

/test e2e-azure

[openshift-ci]

@2uasimojo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure	0c719f6	link	true	/test e2e-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[2uasimojo]

Two CI infra timeouts in a row. Increasing via openshift/release#76486