Skip to content

Conversation

@huangmingxia
Copy link
Contributor

Implement machinepool management utility supporting:

  • adopt: Adopt existing MachineSets into Hive using CPMS utilities
  • create: Create new MachinePool from user configuration
  • detach: Remove MachineSets from Hive management

Platform support: AWS, GCP, Azure, vSphere, Nutanix, OpenStack, IBM Cloud

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2026

@huangmingxia: This pull request references HIVE-3030 which is a valid jira issue.

Details

In response to this:

Implement machinepool management utility supporting:

  • adopt: Adopt existing MachineSets into Hive using CPMS utilities
  • create: Create new MachinePool from user configuration
  • detach: Remove MachineSets from Hive management

Platform support: AWS, GCP, Azure, vSphere, Nutanix, OpenStack, IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@huangmingxia
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2026
@openshift-ci openshift-ci bot requested review from 2uasimojo and dlom January 13, 2026 10:27
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huangmingxia
Once this PR has been reviewed and has the lgtm label, please assign 2uasimojo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 0% with 2259 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.28%. Comparing base (b574bb2) to head (c58c80c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
contrib/pkg/machinepool/create.go 0.00% 547 Missing ⚠️
contrib/pkg/machinepool/analyzer.go 0.00% 359 Missing ⚠️
contrib/pkg/machinepool/adopt.go 0.00% 227 Missing ⚠️
contrib/pkg/machinepool/detach.go 0.00% 212 Missing ⚠️
contrib/pkg/machinepool/builder_nutanix.go 0.00% 163 Missing ⚠️
contrib/pkg/machinepool/builder_gcp.go 0.00% 127 Missing ⚠️
contrib/pkg/machinepool/utils.go 0.00% 127 Missing ⚠️
contrib/pkg/machinepool/builder_aws.go 0.00% 117 Missing ⚠️
contrib/pkg/machinepool/builder.go 0.00% 84 Missing ⚠️
contrib/pkg/machinepool/builder_azure.go 0.00% 77 Missing ⚠️
... and 7 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2828      +/-   ##
==========================================
- Coverage   50.40%   47.28%   -3.13%     
==========================================
  Files         279      295      +16     
  Lines       34194    36453    +2259     
==========================================
  Hits        17235    17235              
- Misses      15595    17854    +2259     
  Partials     1364     1364              
Files with missing lines Coverage Δ
contrib/cmd/hiveutil/main.go 0.00% <0.00%> (ø)
contrib/pkg/machinepool/command.go 0.00% <0.00%> (ø)
contrib/pkg/machinepool/builder_ibmcloud.go 0.00% <0.00%> (ø)
contrib/pkg/machinepool/labels.go 0.00% <0.00%> (ø)
contrib/pkg/machinepool/builder_vsphere.go 0.00% <0.00%> (ø)
contrib/pkg/machinepool/builder_openstack.go 0.00% <0.00%> (ø)
contrib/pkg/machinepool/config.go 0.00% <0.00%> (ø)
contrib/pkg/machinepool/builder_azure.go 0.00% <0.00%> (ø)
contrib/pkg/machinepool/builder.go 0.00% <0.00%> (ø)
contrib/pkg/machinepool/builder_aws.go 0.00% <0.00%> (ø)
... and 7 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Implement machinepool management utility supporting:
- adopt: Adopt existing MachineSets into Hive using CPMS utilities
- create: Create new MachinePool from user configuration
- detach: Remove MachineSets from Hive management

Platform support: AWS, GCP, Azure, vSphere, Nutanix, OpenStack, IBM Cloud
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

@huangmingxia: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants